-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ADR035: offer Amazon S3 for form submissions #179
Add ADR035: offer Amazon S3 for form submissions #179
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah thank you James!
I worry about what happens if the team managing the S3 bucket accidentally changes the bucket access or configuration in a way that stops us being able to upload documents to it... what will happen to form submissions if the S3 upload doesn't work? |
@lfdebrux there's a section on this in the spike doc:
@james-sheppard-gov-uk do you think it's worth incorporating any of that information in here? |
Thanks for your comments @lfdebrux and @DavidBiddle - I've made a few additions, please could you take another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🎉
Rendered view
PR Checklist
- (ADR, decision-record, engagement, research)
What
A new ADR to allow form submissions to be sent to Amazon S3.
How to review
Who can review
Anyone, but in particular those who worked on the Amazon S3 spike.